Conversation
trask
commented
Jul 8, 2025
trask
commented
Jul 8, 2025
.../java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedQuickPulseServlet.java
Show resolved
Hide resolved
trask
commented
Jul 8, 2025
...main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/LiveMetricsVerifier.java
Show resolved
Hide resolved
trask
commented
Jul 8, 2025
Comment on lines
284
to
292
| await().until(mockedIngestion::isReceivingLiveMetrics); | ||
| String contextRootUrl = getBaseUrl() + "/"; | ||
| HttpHelper.getResponseCodeEnsuringSampled(contextRootUrl); | ||
| waitForHealthCheckTelemetry(contextRootUrl); | ||
| await() | ||
| .untilAsserted( | ||
| () -> | ||
| assertThat(mockedIngestion.getLiveMetrics().getRequestCount(contextRootUrl)) | ||
| .isEqualTo(1)); |
Member
Author
There was a problem hiding this comment.
this ensures that live metrics have been sent before resetData is called below
trask
requested review from
harsimar,
jeanbisutti,
rajkumar-rangaraj and
ramthi
as code owners
trask
commented
Jul 8, 2025
Comment on lines
+300
to
+301
| // TODO (trask) need to fix race condition in live metrics | ||
| // where sometimes it loses telemetry |
Member
Author
There was a problem hiding this comment.
I'm working on a separate fix for this in azure-sdk-for-java repo
Member
Author
There was a problem hiding this comment.
Azure/azure-sdk-for-java#45944
I will test it in a separate PR by removing this catch (after this PR is merged)
harsimar
approved these changes
Jul 8, 2025
Member
harsimar
left a comment
harsimar
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.